-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review106389
-----------------------------------------------------------

Ship it!


Currently os.hpp is an all-encompassing header for headers within the os 
directory, so we should add the strerror include accordingly. Also, that means 
for the subsequent patches we don't need to add os/strerror.hpp includes where 
we already have os.hpp includes (although the plan is over time to refine the 
os.hpp includes into more precise includes if that helps compilation speed).


3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (lines 30 - 31)
<https://reviews.apache.org/r/39005/#comment165134>

    Just to match the terminology from the man pages, how about we say 
"XSI-compliant" and "GNU-specific"?



3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (lines 40 - 41)
<https://reviews.apache.org/r/39005/#comment165142>

    Hm.. per our offline chat this condition is a bit off due to the outer 
negation, how about we match the condition from the man page directly?



3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (lines 56 - 59)
<https://reviews.apache.org/r/39005/#comment165143>

    How about we avoid trying to re-use size and buffer and just use a stack 
buffer in this case? Should simplify things a bit?


- Ben Mahler


On Nov. 13, 2015, 4:10 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 4:10 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit also adds test cases for os::strerror (from stout) which can
> only be committed with a libprocess commit -- the corresponding Makefile
> lives there.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 741639a942971e48e2dac42db238d423e61cac21 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 26e1377ee625748b7fdbec327fef9ac602535f83 
>   3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to