----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107122 -----------------------------------------------------------
src/sched/sched.cpp (line 1072) <https://reviews.apache.org/r/40429/#comment166077> I think that we also need to check master.isNone() here. if (master.isNone() || from != master.get().pid()) { src/sched/sched.cpp (line 1073) <https://reviews.apache.org/r/40429/#comment166078> s/VLOG(1)/LOG(WARNING) src/sched/sched.cpp (lines 1079 - 1081) <https://reviews.apache.org/r/40429/#comment166079> Just a question, does their are any guidelines for when to use VLOG(1), VLOG(2) etc? Thanks! - Guangya Liu On 十一月 18, 2015, 9:50 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40429/ > ----------------------------------------------------------- > > (Updated 十一月 18, 2015, 9:50 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-313 > https://issues.apache.org/jira/browse/MESOS-313 > > > Repository: mesos > > > Description > ------- > > Report executor exit to framework schedulers. This is a MVP to start the work > of notifying scheduler on scheduler refresh. > > Next step would be sending this message reliabily, and/or splitting > Event::FAILURE for slave failure and executor termination. > > > Diffs > ----- > > src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 > src/tests/scheduler_event_call_tests.cpp > 39f67a8243db8073d1c9c92c7aeb71854143131d > > Diff: https://reviews.apache.org/r/40429/diff/ > > > Testing > ------- > > Modified test for SchedulerDriverEventTest.Failure, which verifies that > MockScheduler::executorLost is invoked. > > > Thanks, > > Zhitao Li > >