----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review107076 -----------------------------------------------------------
Ship it! LGTM! Just some minor newline nits. src/sched/sched.cpp (line 598) <https://reviews.apache.org/r/40429/#comment166003> Nit: Newline before this line. src/sched/sched.cpp (line 1063) <https://reviews.apache.org/r/40429/#comment166004> Nit: Newline before this line. src/sched/sched.cpp (line 1082) <https://reviews.apache.org/r/40429/#comment166005> nit: kill the newline here. - Anand Mazumdar On Nov. 18, 2015, 7:20 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40429/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 7:20 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-313 > https://issues.apache.org/jira/browse/MESOS-313 > > > Repository: mesos > > > Description > ------- > > Report executor exit to framework schedulers. This is a MVP to start the work > of notifying scheduler on scheduler refresh. > > Next step would be sending this message reliabily, and/or splitting > Event::FAILURE for slave failure and executor termination. > > > Diffs > ----- > > src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048 > src/tests/scheduler_event_call_tests.cpp > 39f67a8243db8073d1c9c92c7aeb71854143131d > > Diff: https://reviews.apache.org/r/40429/diff/ > > > Testing > ------- > > Modified test for SchedulerDriverEventTest.Failure, which verifies that > MockScheduler::executorLost is invoked. > > > Thanks, > > Zhitao Li > >