> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote:
> > src/sched/sched.cpp, line 1073
> > <https://reviews.apache.org/r/40429/diff/3/?file=1131538#file1131538line1073>
> >
> > s/VLOG(1)/LOG(WARNING)
The logging level here is consistent with lostSlave above:
```
if (from != master.get().pid()) {
VLOG(1) << "Ignoring lost slave message because it was sent "
<< "from '" << from << "' instead of the leading master '"
<< master.get().pid() << "'";
return;
}
```
> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote:
> > src/sched/sched.cpp, lines 1079-1081
> > <https://reviews.apache.org/r/40429/diff/3/?file=1131538#file1131538line1079>
> >
> > Just a question, does their are any guidelines for when to use VLOG(1),
> > VLOG(2) etc? Thanks!
Probably someone could document the convention in some getting started document?
> On Nov. 19, 2015, 3:29 a.m., Guangya Liu wrote:
> > src/sched/sched.cpp, line 1072
> > <https://reviews.apache.org/r/40429/diff/3/?file=1131538#file1131538line1072>
> >
> > I think that we also need to check master.isNone() here.
> >
> > if (master.isNone() || from != master.get().pid()) {
The `CHECK_SOME(master)` above should already ensures that master is not None.
This is also consistent with `lostSlave()`
- Zhitao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review107122
-----------------------------------------------------------
On Nov. 18, 2015, 9:50 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 9:50 p.m.)
>
>
> Review request for mesos, Adam B and Vinod Kone.
>
>
> Bugs: MESOS-313
> https://issues.apache.org/jira/browse/MESOS-313
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Report executor exit to framework schedulers. This is a MVP to start the work
> of notifying scheduler on scheduler refresh.
>
> Next step would be sending this message reliabily, and/or splitting
> Event::FAILURE for slave failure and executor termination.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a6faf92ff99cd79c3817684581862fecd1608048
> src/tests/scheduler_event_call_tests.cpp
> 39f67a8243db8073d1c9c92c7aeb71854143131d
>
> Diff: https://reviews.apache.org/r/40429/diff/
>
>
> Testing
> -------
>
> Modified test for SchedulerDriverEventTest.Failure, which verifies that
> MockScheduler::executorLost is invoked.
>
>
> Thanks,
>
> Zhitao Li
>
>
