----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109978 -----------------------------------------------------------
Ship it! Thanks Jie!! src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 36) <https://reviews.apache.org/r/41235/#comment169714> We've been trying to eliminate these in favor of non-namespace using statements and namespace aliases, could you remove it? src/slave/containerizer/mesos/provisioner/docker/puller.cpp (lines 94 - 96) <https://reviews.apache.org/r/41235/#comment169715> No need for the outer Future + CHECK_READY if you're using .then here. Something I'm missing? src/slave/containerizer/mesos/provisioner/docker/puller.cpp (lines 118 - 121) <https://reviews.apache.org/r/41235/#comment169716> Hm.. it would be great to print the status using WSTRINGIFY on the status as we do throughout the rest of the code, any reason not to? - Ben Mahler On Dec. 11, 2015, 1:35 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41235/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 1:35 a.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Cleaned up the untar method in docker puller. > > The extra promise is not needed. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > 4aa4a9c4074d96c30c3bceea59d071feeecae2ea > > Diff: https://reviews.apache.org/r/41235/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
