-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41235/#review109981
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
<https://reviews.apache.org/r/41235/#comment169720>

    Wondering why we removed error context like the name of the file. Wouldnt 
that be great debugging information?



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 107)
<https://reviews.apache.org/r/41235/#comment169723>

    Are we always expecting the future to be ready when we get here?


- Jojy Varghese


On Dec. 11, 2015, 1:35 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41235/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 1:35 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up the untar method in docker puller.
> 
> The extra promise is not needed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
> 
> Diff: https://reviews.apache.org/r/41235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to