> On Dec. 11, 2015, 6:33 p.m., Ben Mahler wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 37
> > <https://reviews.apache.org/r/41235/diff/1/?file=1159660#file1159660line37>
> >
> >     We've been trying to eliminate these in favor of non-namespace using 
> > statements and namespace aliases, could you remove it?

Got it. Will revert this.


> On Dec. 11, 2015, 6:33 p.m., Ben Mahler wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, lines 103-105
> > <https://reviews.apache.org/r/41235/diff/1/?file=1159660#file1159660line103>
> >
> >     No need for the outer Future + CHECK_READY if you're using .then here. 
> > Something I'm missing?

good catch. wish compiler can catch such errors:)


> On Dec. 11, 2015, 6:33 p.m., Ben Mahler wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, lines 147-150
> > <https://reviews.apache.org/r/41235/diff/1/?file=1159660#file1159660line147>
> >
> >     Hm.. it would be great to print the status using WSTRINGIFY on the 
> > status as we do throughout the rest of the code, any reason not to?

Just got to know this function. Thanks Ben!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41235/#review109978
-----------------------------------------------------------


On Dec. 11, 2015, 1:35 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41235/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 1:35 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up the untar method in docker puller.
> 
> The extra promise is not needed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
> 
> Diff: https://reviews.apache.org/r/41235/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to