> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 96 > > <https://reviews.apache.org/r/41235/diff/1/?file=1159660#file1159660line96> > > > > The pattern I have seen in the code is that we dont log failures and it > > pops up the stack and at the place where they are logged, it loses context.
If that's the case, that's something we need to fix:) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109986 ----------------------------------------------------------- On Dec. 11, 2015, 1:35 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41235/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 1:35 a.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Cleaned up the untar method in docker puller. > > The extra promise is not needed. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > 4aa4a9c4074d96c30c3bceea59d071feeecae2ea > > Diff: https://reviews.apache.org/r/41235/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
