----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review110940 -----------------------------------------------------------
Errors in one of the tests, but only minor suggestions otherwise. src/tests/common/http_tests.cpp (lines 78 - 79) <https://reviews.apache.org/r/41381/#comment170956> Can you make these different? Just in case we run into a bug where we report each one as the other, or something equally tricksy src/tests/common/http_tests.cpp (lines 148 - 150) <https://reviews.apache.org/r/41381/#comment170957> There's that nesting again.. src/tests/slave_tests.cpp (lines 2197 - 2199) <https://reviews.apache.org/r/41381/#comment170954> s/port1/port2/? And you call `port2->set_number()` twice. I assume the second one should have been the `port2->set_instance_port()`? src/tests/slave_tests.cpp (line 2240) <https://reviews.apache.org/r/41381/#comment170955> Do you want to verify that the vips are set as expected too? - Adam B On Dec. 16, 2015, 7:32 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41381/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 7:32 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > Added unit test cases to test the new vip and instance_port fields > > > Diffs > ----- > > src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 > src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 > > Diff: https://reviews.apache.org/r/41381/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
