-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111370
-----------------------------------------------------------



src/tests/slave_tests.cpp (line 2238)
<https://reviews.apache.org/r/41381/#comment171532>

    Put a blank line above this comment line.
    Put a space after the `//` so it reads `// Verify`.
    s/retrived/retrieved/
    s/one/ones/



src/tests/slave_tests.cpp (lines 2247 - 2251)
<https://reviews.apache.org/r/41381/#comment171533>

    EXPECT_SOME_EQ here too. Since this was your own test that we just 
committed, let's fix it ourselves now.


- Adam B


On Dec. 18, 2015, 11:58 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 11:58 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to