> On Dec. 19, 2015, 5:49 a.m., Artem Harutyunyan wrote:
> > src/tests/slave_tests.cpp, lines 2242-2246
> > <https://reviews.apache.org/r/41381/diff/7/?file=1170484#file1170484line2242>
> >
> >     How about using EXPECT_SOME_EQ here?

This is much cleaner.


> On Dec. 19, 2015, 5:49 a.m., Artem Harutyunyan wrote:
> > src/tests/slave_tests.cpp, lines 2254-2259
> > <https://reviews.apache.org/r/41381/diff/7/?file=1170484#file1170484line2254>
> >
> >     Ditto as above. But please submit a follow up patch if you decide to 
> > switch these (and possible other) occurences as well.

Will raise a JIRA and a followup patch to change this. Thanks.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review111362
-----------------------------------------------------------


On Dec. 19, 2015, 7:58 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2015, 7:58 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 0ea06341b092cd6ad278075b12dd970b84c84464 
>   src/tests/slave_tests.cpp 109d31c8661c6b91243852e7ee00ce9fa1effe4b 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to