> On Dec. 17, 2015, 11:21 a.m., Adam B wrote:
> > src/tests/slave_tests.cpp, line 2240
> > <https://reviews.apache.org/r/41381/diff/5/?file=1168204#file1168204line2240>
> >
> >     Do you want to verify that the vips are set as expected too?

The vips are part of the DiscoveryInfo and we are already comparing the JSON 
retrieved and the DiscoveryInfo set:
EXPECT_EQ(JSON::Object(JSON::protobuf(discovery)), discoveryObject);

Were you suggesting doing an explicit comparison?


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41381/#review110940
-----------------------------------------------------------


On Dec. 17, 2015, 3:32 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41381/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 3:32 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test cases to test the new vip and instance_port fields
> 
> 
> Diffs
> -----
> 
>   src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
> 
> Diff: https://reviews.apache.org/r/41381/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to