> On Dec. 17, 2015, 11:21 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines 2197-2199 > > <https://reviews.apache.org/r/41381/diff/5/?file=1168204#file1168204line2197> > > > > s/port1/port2/? > > And you call `port2->set_number()` twice. I assume the second one > > should have been the `port2->set_instance_port()`?
Thanks for catching this !! - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review110940 ----------------------------------------------------------- On Dec. 17, 2015, 10:43 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41381/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 10:43 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > Added unit test cases to test the new vip and instance_port fields > > > Diffs > ----- > > src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 > src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 > > Diff: https://reviews.apache.org/r/41381/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
