----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111102 -----------------------------------------------------------
Let's get rid of the Vips message per MPark's recommendation, since we're unlikely to ever add any more fields to that message. include/mesos/mesos.proto (line 1581) <https://reviews.apache.org/r/41380/#comment171084> s/seggregation/segregation/ include/mesos/mesos.proto (lines 1602 - 1607) <https://reviews.apache.org/r/41380/#comment171083> Latest recommendation from MPark is to get rid of the Vips message and just use `repeated Vip vips` everywhere. Then we won't have nested `vips.vips` to jsonify. include/mesos/mesos.proto (line 1638) <https://reviews.apache.org/r/41380/#comment171086> s/end-point/endpoint/? include/mesos/mesos.proto (line 1640) <https://reviews.apache.org/r/41380/#comment171085> `repeated Vip vips = 8;` - Adam B On Dec. 17, 2015, 2:41 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41380/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 2:41 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-4114 > https://issues.apache.org/jira/browse/MESOS-4114 > > > Repository: mesos > > > Description > ------- > > Added repeated vip field to DiscoveryInfo and an instance_port field to Port > > > Diffs > ----- > > include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 > include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 > > Diff: https://reviews.apache.org/r/41380/diff/ > > > Testing > ------- > > make check, and make > > > Thanks, > > Avinash sridharan > >
