> On Dec. 19, 2015, 10:01 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1576-1577 > > <https://reviews.apache.org/r/41380/diff/8/?file=1172691#file1172691line1576> > > > > Do we expect to add more fields to the Vip message later? > > If not, why don't we just add a `repeated string vips` to DiscoveryInfo? > > If so, what do you think we'd add? Maybe a service name, in case the > > same task has multiple services exposed on different vips?
hmm ... Since a VIP is just a virtual IP address. Why not use the existing `Address` message and just add the following to `DiscoveryInfo`: `repeated Address vips;` - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111369 ----------------------------------------------------------- On Dec. 19, 2015, 7:16 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41380/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2015, 7:16 a.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-4114 > https://issues.apache.org/jira/browse/MESOS-4114 > > > Repository: mesos > > > Description > ------- > > Added repeated vip field to DiscoveryInfo and an instance_port field to Port > > > Diffs > ----- > > include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 > include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 > > Diff: https://reviews.apache.org/r/41380/diff/ > > > Testing > ------- > > make check, and make > > > Thanks, > > Avinash sridharan > >
