> On Dec. 18, 2015, 10:54 p.m., Artem Harutyunyan wrote:
> >
> 
> Artem Harutyunyan wrote:
>     Commit messages should usually end with a period.

Fixed.


> On Dec. 18, 2015, 10:54 p.m., Artem Harutyunyan wrote:
> > include/mesos/mesos.proto, line 1579
> > <https://reviews.apache.org/r/41380/diff/6/?file=1170466#file1170466line1579>
> >
> >     s/then/than/?

Thanks. Lot of confusion betweent then and than !! You are right comparison so 
than !!


> On Dec. 18, 2015, 10:54 p.m., Artem Harutyunyan wrote:
> > include/mesos/mesos.proto, line 1603
> > <https://reviews.apache.org/r/41380/diff/6/?file=1170466#file1170466line1603>
> >
> >     Please add a full stop after comment.

Removed the message type Vips as per Adam's suggestion.


> On Dec. 18, 2015, 10:54 p.m., Artem Harutyunyan wrote:
> > include/mesos/mesos.proto, line 1597
> > <https://reviews.apache.org/r/41380/diff/6/?file=1170466#file1170466line1597>
> >
> >     Why is it a Vip and not VIP, or VIp, or maybe even virtual_ip to be 
> > consistent with the style?
> 
> Adam B wrote:
>     Yikes. `VIp` is the worst of those options.
>     I would go with `Vip` according to the Google style guide:
>     "Prefer to capitalize acronyms as single words (i.e. StartRpc(), not 
> StartRPC())." (although that applies to C++ function names)
>     Or `VIP`, since we already have an `ACL` (and `ACLs`).

Oh oh should have been more stubborn sticking with Vip !! I thought VIp is also 
conforming to the coding style. Will go with Vip


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review111222
-----------------------------------------------------------


On Dec. 19, 2015, 7:16 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2015, 7:16 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4114
>     https://issues.apache.org/jira/browse/MESOS-4114
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
> 
> Diff: https://reviews.apache.org/r/41380/diff/
> 
> 
> Testing
> -------
> 
> make check, and make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to