> On Dec. 18, 2015, 2:54 p.m., Artem Harutyunyan wrote: > > include/mesos/mesos.proto, line 1597 > > <https://reviews.apache.org/r/41380/diff/6/?file=1170466#file1170466line1597> > > > > Why is it a Vip and not VIP, or VIp, or maybe even virtual_ip to be > > consistent with the style?
Yikes. `VIp` is the worst of those options. I would go with `Vip` according to the Google style guide: "Prefer to capitalize acronyms as single words (i.e. StartRpc(), not StartRPC())." (although that applies to C++ function names) Or `VIP`, since we already have an `ACL` (and `ACLs`). - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111222 ----------------------------------------------------------- On Dec. 18, 2015, 11:16 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41380/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 11:16 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-4114 > https://issues.apache.org/jira/browse/MESOS-4114 > > > Repository: mesos > > > Description > ------- > > Added repeated vip field to DiscoveryInfo and an instance_port field to Port > > > Diffs > ----- > > include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 > include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 > > Diff: https://reviews.apache.org/r/41380/diff/ > > > Testing > ------- > > make check, and make > > > Thanks, > > Avinash sridharan > >
