----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111222 -----------------------------------------------------------
include/mesos/mesos.proto (line 1579) <https://reviews.apache.org/r/41380/#comment171319> s/then/than/? include/mesos/mesos.proto (line 1597) <https://reviews.apache.org/r/41380/#comment171316> Why is it a Vip and not VIP, or VIp, or maybe even virtual_ip to be consistent with the style? include/mesos/mesos.proto (line 1603) <https://reviews.apache.org/r/41380/#comment171315> Please add a full stop after comment. include/mesos/mesos.proto (line 1638) <https://reviews.apache.org/r/41380/#comment171317> s/used/is used/? include/mesos/v1/mesos.proto (line 1578) <https://reviews.apache.org/r/41380/#comment171318> s/then/than/? include/mesos/v1/mesos.proto (line 1602) <https://reviews.apache.org/r/41380/#comment171320> s/Vip/virtual IPs./ to be consistent with the comment above. And please don't forget the point at the end. include/mesos/v1/mesos.proto (line 1637) <https://reviews.apache.org/r/41380/#comment171418> s/IP used/IPs are used/? - Artem Harutyunyan On Dec. 17, 2015, 2:41 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41380/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 2:41 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Bugs: MESOS-4114 > https://issues.apache.org/jira/browse/MESOS-4114 > > > Repository: mesos > > > Description > ------- > > Added repeated vip field to DiscoveryInfo and an instance_port field to Port > > > Diffs > ----- > > include/mesos/mesos.proto 8ca213062c480f0266ffc51a621eb4a118140c77 > include/mesos/v1/mesos.proto 8f357b0fb778098ec66ac85d174bdd7e387954b5 > > Diff: https://reviews.apache.org/r/41380/diff/ > > > Testing > ------- > > make check, and make > > > Thanks, > > Avinash sridharan > >
