----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review123201 -----------------------------------------------------------
src/master/contender.hpp (lines 17 - 18) <https://reviews.apache.org/r/44545/#comment185410> Nit: Header guard should be this: __MASTER_CONTENDER_ZOOKEEPER_HPP__ src/master/contender.cpp (line 35) <https://reviews.apache.org/r/44545/#comment185412> I'd suggest fully qualifying this include. i.e. `master/contenders/zookeeper.hpp`. src/master/contender.cpp (line 65) <https://reviews.apache.org/r/44545/#comment185413> These aren't yours, but could you fix the spacing here? i.e. s/> >/>>/ Here and everywhere else in these moved files. src/master/contenders/contender.hpp (lines 17 - 18) <https://reviews.apache.org/r/44545/#comment185415> Nit: __MASTER_CONTENDER_STANDALONE_HPP_ src/master/contenders/contender.cpp (lines 30 - 31) <https://reviews.apache.org/r/44545/#comment185417> Ditto: Fully qualify these. src/master/contenders/contender.cpp (line 92) <https://reviews.apache.org/r/44545/#comment185416> Nit: We want to keep 2 newlines between functions. src/master/contenders/standalone.cpp (line 30) <https://reviews.apache.org/r/44545/#comment185418> Ditto: Fully quality this. src/master/detector.hpp (lines 17 - 18) <https://reviews.apache.org/r/44545/#comment185411> Nit: Header guard should be this: __MASTER_CONTENDER_STANDALONE_HPP__ src/master/detector.cpp (line 46) <https://reviews.apache.org/r/44545/#comment185414> Ditto: I suggest fully qualifying this include. src/master/detectors/detector.hpp (lines 17 - 18) <https://reviews.apache.org/r/44545/#comment185419> Nit: __MASTER_DETECTOR_ZOOKEEPER_HPP__ src/master/detectors/detector.cpp (lines 46 - 47) <https://reviews.apache.org/r/44545/#comment185420> Ditto: Fully qualify these. src/master/detectors/standalone.cpp (line 46) <https://reviews.apache.org/r/44545/#comment185421> Ditto: Fully qualify this. src/master/detectors/standalone.cpp (lines 58 - 60) <https://reviews.apache.org/r/44545/#comment185422> I don't see where these helpers are deleted in your later reviews. - Joseph Wu On March 10, 2016, 3:46 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44545/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 3:46 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > Instead of keeping standalone and zookeper contender/detector class > definitions and implementations in the same file, separated them. Also > made the necessary changes in users of class headers to point to the > new locations. > > > Diffs > ----- > > src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 > src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 > src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 > src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 > src/master/contenders/contender.hpp PRE-CREATION > src/master/contenders/contender.cpp PRE-CREATION > src/master/contenders/standalone.cpp PRE-CREATION > src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 > src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e > src/master/detectors/detector.hpp PRE-CREATION > src/master/detectors/detector.cpp PRE-CREATION > src/master/detectors/standalone.cpp PRE-CREATION > src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 > src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8 > src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb > src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 > src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 > src/tests/containerizer/external_containerizer_test.cpp > 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 > src/tests/containerizer/isolator_tests.cpp > 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 > src/tests/fault_tolerance_tests.cpp > d193897e636efd0e3ef67bf67fcd6255a3de0341 > src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf > src/tests/master_allocator_tests.cpp > cba7c36471f93b678d94e1da0251a28a893696b1 > src/tests/master_authorization_tests.cpp > 29c89fb11da792c3e71eb880a19657ea225b3cc8 > src/tests/master_contender_detector_tests.cpp > 255ab8119a04b55bb4f1b61dee19c4be64499376 > src/tests/master_slave_reconciliation_tests.cpp > d41178eb41df519073fc0890c5716bbc9fed6ad2 > src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 > src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8 > src/tests/oversubscription_tests.cpp > e528476cd83b0e3f7ae8cea7d86dfabc1f66484e > src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 > src/tests/persistent_volume_tests.cpp > bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 > src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 > src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 > src/tests/scheduler_event_call_tests.cpp > 8c02ceeb3ec1783cb2f63f100700508e70f586e4 > src/tests/scheduler_http_api_tests.cpp > dfb0f51fec67a3951e396eab28eedb0dbf9493ae > src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 > src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c > src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 > > Diff: https://reviews.apache.org/r/44545/diff/ > > > Testing > ------- > > > Thanks, > > Anurag Singh > >
