----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review126356 -----------------------------------------------------------
src/master/flags.cpp (line 483) <https://reviews.apache.org/r/44670/#comment189345> What is meant by a 'class' here? src/master/main.cpp (line 241) <https://reviews.apache.org/r/44670/#comment189353> Can you align it with the paren (here and below)? src/master/main.cpp (lines 247 - 248) <https://reviews.apache.org/r/44670/#comment189347> These two should fit on one line :-). src/master/main.cpp (line 360) <https://reviews.apache.org/r/44670/#comment189348> The typecast is unnecessary here. src/master/main.cpp (line 363) <https://reviews.apache.org/r/44670/#comment189349> ditto. src/master/main.cpp (line 366) <https://reviews.apache.org/r/44670/#comment189352> `contender_.get() == nullptr` will never be true, correct? Similarly, for detector. src/master/main.cpp (line 376) <https://reviews.apache.org/r/44670/#comment189350> ditto src/master/main.cpp (line 379) <https://reviews.apache.org/r/44670/#comment189351> ditto src/slave/main.cpp (line 167) <https://reviews.apache.org/r/44670/#comment189354> Align with paren (here and below). src/slave/main.cpp (line 273) <https://reviews.apache.org/r/44670/#comment189355> remove typecase, here and below. src/slave/main.cpp (line 279) <https://reviews.apache.org/r/44670/#comment189356> The second expression will never be true, correct? - Kapil Arya On March 23, 2016, 7:06 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44670/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 7:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > The master_detector and master_contender flags allow modules to be > used for specifying the MasterContender and MasterDetector > implementations to use. > > > Diffs > ----- > > src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d > src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 > src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 > src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 > > Diff: https://reviews.apache.org/r/44670/diff/ > > > Testing > ------- > > In addition to all unit tests passing, we are currently using this > functionality in our environment with a custom consensus stack. In our world, > we have a C++ plugin that calls out to an HTTP REST service (implemented in > Java/Scala, not that it matters). > > > Thanks, > > Anurag Singh > >
