----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review123633 -----------------------------------------------------------
Patch looks great! Reviews applied: [44287, 44288, 44543, 44544, 44545, 44546, 44547, 44289, 44669, 44670] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 15, 2016, 6:18 a.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44670/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 6:18 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > The master_detector and master_contender flags allow modules to be > used for specifying the MasterContender and MasterDetector > implementations to use. > > > Diffs > ----- > > src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d > src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 > src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd > src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb > > Diff: https://reviews.apache.org/r/44670/diff/ > > > Testing > ------- > > In addition to all unit tests passing, we are currently using this > functionality in our environment with a custom consensus stack. In our world, > we have a C++ plugin that calls out to an HTTP REST service (implemented in > Java/Scala, not that it matters). > > > Thanks, > > Anurag Singh > >
