----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review127428 -----------------------------------------------------------
Bad patch! Reviews applied: [44670, 44669, 44289, 44547, 44546, 44545, 44544, 44543, 44288, 44287] Failed command: ./support/apply-review.sh -n -r 44288 Error: 2016-04-06 19:36:50 URL:https://reviews.apache.org/r/44288/diff/raw/ [50506/50506] -> "44288.patch" [1] error: src/tests/monitor_tests.cpp: does not exist in index error: patch failed: src/tests/oversubscription_tests.cpp:58 error: src/tests/oversubscription_tests.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/12362/console - Mesos ReviewBot On April 6, 2016, 4:03 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44670/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 4:03 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > The master_detector and master_contender flags allow modules to be > used for specifying the MasterContender and MasterDetector > implementations to use. > > > Diffs > ----- > > src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d > src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 > src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c > src/slave/flags.hpp 69e1b01e09d2a15bee5e0745b751f47aaefe3fbe > src/slave/flags.cpp 315cf47d268bce0a0255a061d64e414c736c8125 > src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea > > Diff: https://reviews.apache.org/r/44670/diff/ > > > Testing > ------- > > In addition to all unit tests passing, we are currently using this > functionality in our environment with a custom consensus stack. In our world, > we have a C++ plugin that calls out to an HTTP REST service (implemented in > Java/Scala, not that it matters). > > > Thanks, > > Anurag Singh > >
