> On April 26, 2016, 9 a.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, line 171 > > <https://reviews.apache.org/r/46569/diff/3/?file=1359591#file1359591line171> > > > > s/some agent's endpoint/the specified agent endpoint/
Done. > On April 26, 2016, 9 a.m., Adam B wrote: > > src/tests/slave_authorization_tests.cpp, line 251 > > <https://reviews.apache.org/r/46569/diff/3/?file=1359591#file1359591line251> > > > > What does this parameter say/do? This is used to construct case names and will be the prefix. I picked the same string as used for the fixture in this file for easier discoverablity; note however that since parameterized tests construct new fixture names from both prefix and case name on the preprocessor level, this will not result in a name conflict. In this case the added test cases will be called like this SlaveAuthorizationTest/EndpointAuthorization. Endpoint/0 # GetParam() = "monitor/statistics" Endpoint/1 # GetParam() = "monitor/statistics.json" - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130548 ----------------------------------------------------------- On April 26, 2016, 9:59 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46569/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 9:59 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-5164 > https://issues.apache.org/jira/browse/MESOS-5164 > > > Repository: mesos > > > Description > ------- > > At the moment we only provide a harness for `GET` methods, but will > generalize this further once we authorize `POST` requests against > agent endpoints as well. > > > Diffs > ----- > > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46569/diff/ > > > Testing > ------- > > make check (OS X, clang trunk w/o optimization) > > > Thanks, > > Benjamin Bannier > >
