> On April 26, 2016, 6:45 p.m., Alexander Rukletsov wrote:
> > src/tests/slave_authorization_tests.cpp, line 251
> > <https://reviews.apache.org/r/46569/diff/4/?file=1361120#file1361120line251>
> >
> >     s/SlaveAuthorizationTest/Endpoint
> >     
> >     I'd say it's more descriptive.

Right now the tests will appear as e.g., 
`SlaveAuthorizationTest/EndpointAuthorization.Endpoint/0`. I do not agree that 
calling them `Endpoint/EndpointAuthorization.Endpoint/0` is more descriptive.


> On April 26, 2016, 6:45 p.m., Alexander Rukletsov wrote:
> > src/tests/slave_authorization_tests.cpp, lines 172-173
> > <https://reviews.apache.org/r/46569/diff/4/?file=1361120#file1361120line172>
> >
> >     Ooops, `{` belongs to a separate line.

Ups, fixed now.


> On April 26, 2016, 6:45 p.m., Alexander Rukletsov wrote:
> > src/tests/slave_authorization_tests.cpp, lines 218-219
> > <https://reviews.apache.org/r/46569/diff/4/?file=1361120#file1361120line218>
> >
> >     Let's not wrap it, it reduces readability!

So be it.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46569/#review130638
-----------------------------------------------------------


On April 26, 2016, 8:22 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46569/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 8:22 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-5164
>     https://issues.apache.org/jira/browse/MESOS-5164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> At the moment we only provide a harness for `GET` methods, but will
> generalize this further once we authorize `POST` requests against
> agent endpoints as well.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_authorization_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46569/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang trunk w/o optimization)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to