-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46569/#review130638
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_authorization_tests.cpp (line 172)
<https://reviews.apache.org/r/46569/#comment194452>

    Ooops, `{` belongs to a separate line.



src/tests/slave_authorization_tests.cpp (line 215)
<https://reviews.apache.org/r/46569/#comment194453>

    Let's not wrap it, it reduces readability!



src/tests/slave_authorization_tests.cpp (lines 244 - 249)
<https://reviews.apache.org/r/46569/#comment194451>

    Does it make sense to pull it up, around L169?



src/tests/slave_authorization_tests.cpp (line 246)
<https://reviews.apache.org/r/46569/#comment194450>

    s/SlaveAuthorizationTest/Endpoint
    
    I'd say it's more descriptive.


- Alexander Rukletsov


On April 26, 2016, 7:59 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46569/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 7:59 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-5164
>     https://issues.apache.org/jira/browse/MESOS-5164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> At the moment we only provide a harness for `GET` methods, but will
> generalize this further once we authorize `POST` requests against
> agent endpoints as well.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_authorization_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46569/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, clang trunk w/o optimization)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to