> On April 26, 2016, 6:45 p.m., Alexander Rukletsov wrote: > > src/tests/slave_authorization_tests.cpp, line 251 > > <https://reviews.apache.org/r/46569/diff/4/?file=1361120#file1361120line251> > > > > s/SlaveAuthorizationTest/Endpoint > > > > I'd say it's more descriptive. > > Benjamin Bannier wrote: > Right now the tests will appear as e.g., > `SlaveAuthorizationTest/EndpointAuthorization.Endpoint/0`. I do not agree > that calling them `Endpoint/EndpointAuthorization.Endpoint/0` is more > descriptive.
I updated the test names (multiple now), they are now called e.g., `Endpoint/SlaveCoarseGrainedAuthorization.AuthorizationRequest/0`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46569/#review130638 ----------------------------------------------------------- On April 27, 2016, 10:59 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46569/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 10:59 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-5164 > https://issues.apache.org/jira/browse/MESOS-5164 > > > Repository: mesos > > > Description > ------- > > At the moment we only provide a harness for `GET` methods, but will > generalize this further once we authorize `POST` requests against > agent endpoints as well. > > > Diffs > ----- > > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46569/diff/ > > > Testing > ------- > > make check (OS X, clang trunk w/o optimization) > > > Thanks, > > Benjamin Bannier > >
