> On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, lines 100-101 > > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line100> > > > > What happens if a network that is in use (by containers) is removed > > from the config and agent restarted? What if the network config is updated? > > Is that all safe? > > Avinash sridharan wrote: > Thanks !! This is an important point that I missed. Currently we are not > checkpointing the CNI configuration for a given container. This implies that > if the current CNI config is modified or deleted, it won't affect container > operation, or even Agent restart, but it will impact deletion of containers. > Since the plugin information in the CNI config might have changed, resulting > in the plugin throwing an error when it tries to delete the veth and release > IP address from the container network namespace. > > I will add a `### Limiations` section describing this behavior. We have > https://issues.apache.org/jira/browse/MESOS-5310 to address this issue.
Added a ### Limitations section. > On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 247 > > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line247> > > > > and vice versa unless the executor uses HTTP API? Even with the HTTP API the requirement of routeability (in both directions) would still hold right? > On May 18, 2016, 6:39 p.m., Vinod Kone wrote: > > docs/cni.md, line 255 > > <https://reviews.apache.org/r/47463/diff/3/?file=1386244#file1386244line255> > > > > s/existing// ? s/existing/egressing - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47463/#review133782 ----------------------------------------------------------- On May 19, 2016, 6:38 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47463/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 6:38 p.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, Kevin Klues, Neil Conway, > Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-4771 > https://issues.apache.org/jira/browse/MESOS-4771 > > > Repository: mesos > > > Description > ------- > > Added documentation for `network/cni` isolator. > > > Diffs > ----- > > docs/cni.md PRE-CREATION > > Diff: https://reviews.apache.org/r/47463/diff/ > > > Testing > ------- > > Build the documentation website and verified the rendering. > > You can review a rendering of the markdown on my github: > https://github.com/asridharan/mesos/blob/MESOS-4771/docs/cni.md > > > Thanks, > > Avinash sridharan > >
