----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139312 -----------------------------------------------------------
LGTM overall. include/mesos/master/master.proto (line 64) <https://reviews.apache.org/r/49157/#comment204486> s/weights/role weights/ include/mesos/master/master.proto (line 144) <https://reviews.apache.org/r/49157/#comment204487> s/then// include/mesos/master/master.proto (line 147) <https://reviews.apache.org/r/49157/#comment204488> Volume creation can be verified by sending a `GET_VOLUMES` call. include/mesos/master/master.proto (line 153) <https://reviews.apache.org/r/49157/#comment204489> s/then// include/mesos/master/master.proto (line 156) <https://reviews.apache.org/r/49157/#comment204490> Volume deletion can be verified by sending a `GET_VOLUMES` call. include/mesos/master/master.proto (line 319) <https://reviews.apache.org/r/49157/#comment204491> can you include informaation about which roles weights are listed here? for every role listed above? - Vinod Kone On June 23, 2016, 3:47 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49157/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 3:47 p.m.) > > > Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay > Guo, Shuai Lin, and Vinod Kone. > > > Bugs: MESOS-5695 > https://issues.apache.org/jira/browse/MESOS-5695 > > > Repository: mesos > > > Description > ------- > > Add missing comments for `GET_ROLES`, `GET_WEIGHTS`, `SUBSCRIBE`, > `CREATE_VOLUMES`, `DESTROY_VOLUMES`, `SET_QUOTA` in operator API > protos. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > > Diff: https://reviews.apache.org/r/49157/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
