> On June 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > <https://reviews.apache.org/r/49157/diff/1/?file=1428649#file1428649line319> > > > > can you include informaation about which roles weights are listed here? > > for every role listed above? > > haosdent huang wrote: > Yes, I think this call is duplicated with `GET_ROLES`. > > ``` > // TODO(Yongqiao Wang): `/roles` endpoint also shows the weights > information, > // consider erasing the duplicated information later. > if (request.method == "GET") { > return weightsHandler.get(request, principal); > } > ``` > > Should we double check with @adam and @yongqiao and remove it if it > duplicated? > > zhou xing wrote: > Yes, in fact, the getWeights call will check all the roles and only show > the weights of the roles that are granted access to the user. > please goto @adam to confirm we can remove it now.
Thanks @dongdong's reply, just send out the emails to @adam and @yongqiao. :-) - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139312 ----------------------------------------------------------- On June 24, 2016, 1:58 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49157/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 1:58 a.m.) > > > Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay > Guo, Shuai Lin, and Vinod Kone. > > > Bugs: MESOS-5695 > https://issues.apache.org/jira/browse/MESOS-5695 > > > Repository: mesos > > > Description > ------- > > Add missing comments for `GET_ROLES`, `GET_WEIGHTS`, `SUBSCRIBE`, > `CREATE_VOLUMES`, `DESTROY_VOLUMES`, `SET_QUOTA` in operator API > protos. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > src/master/master.cpp d89c049326358bad509bb1455c81eb11610eeeb8 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 92b33111799cb4e1c8bc2051381e1254d701d95c > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > 7678a7c81c3cdb27410c1f066021eb34bd02a83f > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > f9056c90f1075cb19c4f554e7d5b629561d06035 > src/tests/containerizer/cni_isolator_tests.cpp > 991823b96f8eac7539625ef0f1e045e6a10464ac > > Diff: https://reviews.apache.org/r/49157/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
