----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139404 -----------------------------------------------------------
include/mesos/master/master.proto (line 150) <https://reviews.apache.org/r/49157/#comment204621> whoops.. Bad copy paste? include/mesos/master/master.proto (line 159) <https://reviews.apache.org/r/49157/#comment204622> Ditto include/mesos/master/master.proto (line 307) <https://reviews.apache.org/r/49157/#comment204623> hmmm.. we should consider doing a sweep to kill: `The response for 'Call::GET_X`. or introduce it for every Response type. Currently, some of them have it and some don't. Also, it's pretty self-explanatory that `GetX` message refers to the `Response` for `GET_X` call, no? include/mesos/master/master.proto (lines 320 - 321) <https://reviews.apache.org/r/49157/#comment204625> Can we remove the information about principal etc.? We might consider introducing more information on AuthZ for all handlers sometime in the future. - Anand Mazumdar On June 24, 2016, 1:58 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49157/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 1:58 a.m.) > > > Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay > Guo, Shuai Lin, and Vinod Kone. > > > Bugs: MESOS-5695 > https://issues.apache.org/jira/browse/MESOS-5695 > > > Repository: mesos > > > Description > ------- > > Add missing comments for `GET_ROLES`, `GET_WEIGHTS`, `SUBSCRIBE`, > `CREATE_VOLUMES`, `DESTROY_VOLUMES`, `SET_QUOTA` in operator API > protos. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > src/master/master.cpp d89c049326358bad509bb1455c81eb11610eeeb8 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 92b33111799cb4e1c8bc2051381e1254d701d95c > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > 7678a7c81c3cdb27410c1f066021eb34bd02a83f > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > f9056c90f1075cb19c4f554e7d5b629561d06035 > src/tests/containerizer/cni_isolator_tests.cpp > 991823b96f8eac7539625ef0f1e045e6a10464ac > > Diff: https://reviews.apache.org/r/49157/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
