> On June 24, 2016, 9:25 p.m., Anand Mazumdar wrote: > > include/mesos/master/master.proto, line 307 > > <https://reviews.apache.org/r/49157/diff/3/?file=1428957#file1428957line307> > > > > hmmm.. we should consider doing a sweep to kill: > > > > `The response for 'Call::GET_X`. > > > > or introduce it for every Response type. Currently, some of them have > > it and some don't. Also, it's pretty self-explanatory that `GetX` message > > refers to the `Response` for `GET_X` call, no? > > haosdent huang wrote: > I think it would better to add it, because > > ``` > message GetFileContents { > repeated bytes data = 1; > } > ``` > > is the response for `Call::READ_FILE`.
I add the missing `The response for 'Call::GET_X`, do you think we should add them only when necessary? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139404 ----------------------------------------------------------- On June 25, 2016, 6:44 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49157/ > ----------------------------------------------------------- > > (Updated June 25, 2016, 6:44 p.m.) > > > Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay > Guo, Shuai Lin, and Vinod Kone. > > > Bugs: MESOS-5695 > https://issues.apache.org/jira/browse/MESOS-5695 > > > Repository: mesos > > > Description > ------- > > Add missing comments for `GET_ROLES`, `GET_WEIGHTS`, `SUBSCRIBE`, > `CREATE_VOLUMES`, `DESTROY_VOLUMES`, `SET_QUOTA` in operator API > protos. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > > Diff: https://reviews.apache.org/r/49157/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
