> On 六月 24, 2016, 12:27 a.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 319 > > <https://reviews.apache.org/r/49157/diff/1/?file=1428649#file1428649line319> > > > > can you include informaation about which roles weights are listed here? > > for every role listed above? > > haosdent huang wrote: > Yes, I think this call is duplicated with `GET_ROLES`. > > ``` > // TODO(Yongqiao Wang): `/roles` endpoint also shows the weights > information, > // consider erasing the duplicated information later. > if (request.method == "GET") { > return weightsHandler.get(request, principal); > } > ``` > > Should we double check with @adam and @yongqiao and remove it if it > duplicated?
Yes, in fact, the getWeights call will check all the roles and only show the weights of the roles that are granted access to the user. please goto @adam to confirm we can remove it now. - zhou ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49157/#review139312 ----------------------------------------------------------- On 六月 23, 2016, 3:47 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49157/ > ----------------------------------------------------------- > > (Updated 六月 23, 2016, 3:47 p.m.) > > > Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay > Guo, Shuai Lin, and Vinod Kone. > > > Bugs: MESOS-5695 > https://issues.apache.org/jira/browse/MESOS-5695 > > > Repository: mesos > > > Description > ------- > > Add missing comments for `GET_ROLES`, `GET_WEIGHTS`, `SUBSCRIBE`, > `CREATE_VOLUMES`, `DESTROY_VOLUMES`, `SET_QUOTA` in operator API > protos. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > > Diff: https://reviews.apache.org/r/49157/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
