----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/#review153781 -----------------------------------------------------------
Looks good except for the DestroyVolume principal. Close to shippable. include/mesos/authorizer/authorizer.proto (line 68) <https://reviews.apache.org/r/52600/#comment223246> s/vaue/value/ include/mesos/authorizer/authorizer.proto (line 69) <https://reviews.apache.org/r/52600/#comment223245> "It" is ambiguous after talking about the other variant. How about "REGISTER_FRAMEWORK sets an object..." src/authorizer/local/authorizer.cpp (line 275) <https://reviews.apache.org/r/52600/#comment223247> Is the reservation principal guaranteed to be the same principal that created the volume? What about `resource->disk->persistence->principal`? - Adam B On Oct. 24, 2016, 1:31 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52600/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 1:31 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Till Toenshoff. > > > Bugs: MESOS-6401 > https://issues.apache.org/jira/browse/MESOS-6401 > > > Repository: mesos > > > Description > ------- > > Updates the authorizer interfaces and well as the local authorizer, > such that all actions which were limited to use a _role_ or a > _principal_ as an object, are able to use whole protobuf messages > as objects. This change enables more sophisticated authorization > mechanisms. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > cb365c7d8d088f2810bde11b72dc20843a18fa51 > include/mesos/authorizer/authorizer.proto > b6a9f142eecbdfd59210872a92e3126f04de334c > src/authorizer/local/authorizer.cpp > f1dff65d973fc84f4171f68fd0391a2343a96965 > > Diff: https://reviews.apache.org/r/52600/diff/ > > > Testing > ------- > > tests in the last patch of the chain. > > > Thanks, > > Alexander Rojas > >
