> On Nov. 15, 2016, 6:53 p.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, lines 231-233 > > <https://reviews.apache.org/r/52600/diff/7/?file=1555485#file1555485line231> > > > > Ooh, only 2 left using 'value'. I wonder if we can ever get rid of it > > completely, maybe add explicit "role" and "path" fields to replace it.
Not necessary for this patchset. Just thinking out loud. > On Nov. 15, 2016, 6:53 p.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, line 238 > > <https://reviews.apache.org/r/52600/diff/7/?file=1555485#file1555485line238> > > > > Should these have a chance at ANY if object->value is NULL? They didn't before, so I'm assuming that's still fine. Value will always be set. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/#review156015 ----------------------------------------------------------- On Nov. 7, 2016, 7:29 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52600/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 7:29 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Till Toenshoff. > > > Bugs: MESOS-6401 > https://issues.apache.org/jira/browse/MESOS-6401 > > > Repository: mesos > > > Description > ------- > > Updates the authorizer interfaces and well as the local authorizer, > such that all actions which were limited to use a _role_ or a > _principal_ as an object, are able to use whole protobuf messages > as objects. This change enables more sofisticated authorization > mechanisms. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > cb365c7d8d088f2810bde11b72dc20843a18fa51 > include/mesos/authorizer/authorizer.proto > b6a9f142eecbdfd59210872a92e3126f04de334c > src/authorizer/local/authorizer.cpp > f1dff65d973fc84f4171f68fd0391a2343a96965 > > Diff: https://reviews.apache.org/r/52600/diff/ > > > Testing > ------- > > tests in the last patch of the chain. > > > Thanks, > > Alexander Rojas > >
