> On Nov. 15, 2016, 6:53 p.m., Adam B wrote: > > Looks great! Just a couple of nits.
Fixing the nits myself and committing. > On Nov. 15, 2016, 6:53 p.m., Adam B wrote: > > include/mesos/authorizer/authorizer.proto, lines 68-69 > > <https://reviews.apache.org/r/52600/diff/7/?file=1555484#file1555484line68> > > > > Let's reorder this to put the important information first, and the > > deprecation note after. > > > > `REGISTER_FRAMEWORK` sets an object of type `FrameworkInfo`. The > > `value` field is no longer used. > > The `_WITH_ROLE` variant is deprecated and will be removed after Mesos > > 1.2's deprecation cycle ends. Technically `value` is still set until the deprecation cycle ends, so let me correct this to: `REGISTER_FRAMEWORK` will have an object with `FrameworkInfo` set. The `_WITH_ROLE` alias is deprecated and will be removed after Mesos 1.2's deprecation cycle ends. The `value` field will continue to be set until that time. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52600/#review156015 ----------------------------------------------------------- On Nov. 7, 2016, 7:29 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52600/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 7:29 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Till Toenshoff. > > > Bugs: MESOS-6401 > https://issues.apache.org/jira/browse/MESOS-6401 > > > Repository: mesos > > > Description > ------- > > Updates the authorizer interfaces and well as the local authorizer, > such that all actions which were limited to use a _role_ or a > _principal_ as an object, are able to use whole protobuf messages > as objects. This change enables more sofisticated authorization > mechanisms. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > cb365c7d8d088f2810bde11b72dc20843a18fa51 > include/mesos/authorizer/authorizer.proto > b6a9f142eecbdfd59210872a92e3126f04de334c > src/authorizer/local/authorizer.cpp > f1dff65d973fc84f4171f68fd0391a2343a96965 > > Diff: https://reviews.apache.org/r/52600/diff/ > > > Testing > ------- > > tests in the last patch of the chain. > > > Thanks, > > Alexander Rojas > >
