> On Jan. 16, 2017, 12:58 p.m., Jay Guo wrote: > > src/master/master.cpp, lines 2491-2492 > > <https://reviews.apache.org/r/55271/diff/5/?file=1603888#file1603888line2491> > > > > Note that you could use `framework.capabilities` here since > > https://reviews.apache.org/r/55021/ is landed. > > Benjamin Bannier wrote: > Done, also for the other call to `protobuf::frameworkHasCapabilities` > added as part of this patch. > > We should probably also the remove the other uses of > `protobuf::frameworkHasCapabilities`. Do you already have a patch for that?
Some of them are done in https://reviews.apache.org/r/55066/ and https://reviews.apache.org/r/55068/ feel free to post another patch if I miss something. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161678 ----------------------------------------------------------- On Jan. 16, 2017, 5:54 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55271/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 5:54 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > We currently do not allow `MULTI_ROLE` frameworks to change their > roles. This restriction will be lifted later. > > > Diffs > ----- > > src/master/master.cpp b863ff6e93931c3d1ee056248084c7f44caf2fd9 > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55271/diff/ > > > Testing > ------- > > Tested on various Linux configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
