> On Jan. 16, 2017, 5:58 a.m., Jay Guo wrote: > > src/master/master.cpp, line 2478 > > <https://reviews.apache.org/r/55271/diff/5/?file=1603888#file1603888line2478> > > > > I think we don't necessarily have `framework` here if framework > > information hasn't been reconstructed from agent failover yet. See > > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L2563-L2571 > > > > I feel that we need to introduce a cross-checking validation that > > checks "new" frameworkInfo against "old" one if available. And this may be > > done in `updateFrameworkInfo`? > > Benjamin Bannier wrote: > Very good point. I agree that moving all these checks to > `updateFrameworkInfo` makes most sense as there we have all needed > information, however it currently returns just `void` where instead we > probably need a `Try<Nothing>`. Let me try to improve `updateFrameworkInfo` > so we can check there.
I moved the validation to `updateFrameworkInfo` after changing it so it can return an error (in previous patch). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161678 ----------------------------------------------------------- On Jan. 16, 2017, 12:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55271/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 12:28 p.m.) > > > Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. > > > Bugs: MESOS-6631 > https://issues.apache.org/jira/browse/MESOS-6631 > > > Repository: mesos > > > Description > ------- > > We currently do not allow `MULTI_ROLE` frameworks to change their > roles. This restriction will be lifted later. > > > Diffs > ----- > > src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004 > src/tests/master_validation_tests.cpp > e5d55e03648cb218d42adc594d6fa7d40ea9bcbb > > Diff: https://reviews.apache.org/r/55271/diff/ > > > Testing > ------- > > Tested on various Linux configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
