----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review167860 -----------------------------------------------------------
LGTM modulo addressing the existing issues. src/tests/check_tests.cpp Lines 74-79 (patched) <https://reviews.apache.org/r/56213/#comment239819> I don't know enough about power shell syntax. Did you confirm with a windows expert that this is the right way to do it? cc @josephwu @mpark @joris? - Vinod Kone On March 1, 2017, 12:50 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56213/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 12:50 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe > > > Diff: https://reviews.apache.org/r/56213/diff/4/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
