> On Feb. 15, 2017, 1:41 p.m., Gastón Kleiman wrote: > > src/tests/check_tests.cpp > > Lines 620-625 (patched) > > <https://reviews.apache.org/r/56213/diff/3/?file=1627707#file1627707line620> > > > > This has the potential of being flaky on a very busy box. > > > > A more robust approach could set the grace period to MAX_INT, and make > > the health check pass iff a file created by the check exists.
Or does not depend on which update comes first. I'll add a TODO for now, which we can fix once we actually see this test being flaky. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review165568 ----------------------------------------------------------- On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56213/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 4:46 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > src/tests/mesos.hpp f39e243c2c11bc1c9c757049fda2122727d1fef9 > > > Diff: https://reviews.apache.org/r/56213/diff/7/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
