----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178786 -----------------------------------------------------------
src/linux/routing/queueing/htb.cpp Lines 144-145 (patched) <https://reviews.apache.org/r/60203/#comment252974> shouldn't ClassConfig also use uint32_t for rate, ceil and cburst? src/linux/routing/queueing/internal.hpp Lines 342 (patched) <https://reviews.apache.org/r/60203/#comment252977> There's `exists`, `create` and `remove` for for qdisc, and similar functions with `Class` suffix for class. I think we should make naming consistent for them. src/linux/routing/queueing/internal.hpp Lines 566 (patched) <https://reviews.apache.org/r/60203/#comment252976> s/clas/class/ - Dmitry Zhuk On June 19, 2017, 7:36 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60203/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 7:36 p.m.) > > > Review request for mesos, Ilya Pronin, Jie Yu, Santhosh Kumar Shanmugham, and > Cong Wang. > > > Repository: mesos > > > Description > ------- > > Based heavily on Cong Wang's original review 45605. > > Introduce support for HTB class and expose configuration. > > > Diffs > ----- > > src/linux/routing/queueing/class.hpp PRE-CREATION > src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 > src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f > src/linux/routing/queueing/internal.hpp > 9fe522ee017c86af8c7b2e518cd0957af08750e4 > > > Diff: https://reviews.apache.org/r/60203/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
