----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178789 -----------------------------------------------------------
Looks solid to me. Comments below are mostly style issues. src/linux/routing/queueing/htb.hpp Lines 49 (patched) <https://reviews.apache.org/r/60203/#comment252981> Style: for functions the opening brace should be on a separate line. src/linux/routing/queueing/htb.hpp Lines 58-61 (patched) <https://reviews.apache.org/r/60203/#comment252984> libnl uses `uint32_t` for these. If we use `uint64_t` we have to check that the value. Plus we'll get a warning without an explicit cast. src/linux/routing/queueing/htb.hpp Lines 102 (patched) <https://reviews.apache.org/r/60203/#comment252985> Maybe `classExists()`? src/linux/routing/queueing/internal.hpp Lines 256-259 (patched) <https://reviews.apache.org/r/60203/#comment252991> If the link doesn't exist `rtnl_link_get_ifindex()` will return 0. Is it OK here? Will it simply dump all existing classes? Would we want to return an error in such case? src/linux/routing/queueing/internal.hpp Lines 274-279 (patched) <https://reviews.apache.org/r/60203/#comment252990> Style: The code inside `if` is overindented. src/linux/routing/queueing/internal.hpp Lines 566 (patched) <https://reviews.apache.org/r/60203/#comment252995> Spelling: s/Removs/Removes/, s/clas/class/ src/linux/routing/queueing/internal.hpp Lines 569-572 (patched) <https://reviews.apache.org/r/60203/#comment252996> Style: function parameters should be indented with 4 spaces. src/linux/routing/queueing/internal.hpp Lines 595-597 (patched) <https://reviews.apache.org/r/60203/#comment253001> Why don't we handle this here to be consistent with other `*Class()` functions? - Ilya Pronin On June 19, 2017, 8:36 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60203/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 8:36 p.m.) > > > Review request for mesos, Ilya Pronin, Jie Yu, Santhosh Kumar Shanmugham, and > Cong Wang. > > > Repository: mesos > > > Description > ------- > > Based heavily on Cong Wang's original review 45605. > > Introduce support for HTB class and expose configuration. > > > Diffs > ----- > > src/linux/routing/queueing/class.hpp PRE-CREATION > src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 > src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f > src/linux/routing/queueing/internal.hpp > 9fe522ee017c86af8c7b2e518cd0957af08750e4 > > > Diff: https://reviews.apache.org/r/60203/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
