----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review179425 -----------------------------------------------------------
Fix it, then Ship it! src/linux/routing/queueing/class.hpp Lines 31-35 (patched) <https://reviews.apache.org/r/60203/#comment254122> I'd move this to internal.hpp to be consistent with others. src/linux/routing/queueing/htb.hpp Lines 69 (patched) <https://reviews.apache.org/r/60203/#comment254125> i like the namespace idea. Can we put qdisc related functions under `qdisc` namespace? src/linux/routing/queueing/htb.cpp Line 41 (original), 45 (patched) <https://reviews.apache.org/r/60203/#comment254126> This can be qdisk::Config (similar to cls::Config)! src/linux/routing/queueing/htb.cpp Lines 195 (patched) <https://reviews.apache.org/r/60203/#comment254128> 2 lines apart src/linux/routing/queueing/internal.hpp Lines 127 (patched) <https://reviews.apache.org/r/60203/#comment254127> one line above - Jie Yu On June 30, 2017, 11:01 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60203/ > ----------------------------------------------------------- > > (Updated June 30, 2017, 11:01 p.m.) > > > Review request for mesos, Ilya Pronin, Jie Yu, Santhosh Kumar Shanmugham, and > Cong Wang. > > > Repository: mesos > > > Description > ------- > > Based heavily on Cong Wang's original review 45605. > > Introduce support for HTB class and expose configuration. > > > Diffs > ----- > > src/linux/routing/queueing/class.hpp PRE-CREATION > src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 > src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f > src/linux/routing/queueing/internal.hpp > 9fe522ee017c86af8c7b2e518cd0957af08750e4 > > > Diff: https://reviews.apache.org/r/60203/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
