> On June 23, 2017, 6:02 a.m., Ilya Pronin wrote: > > src/linux/routing/queueing/internal.hpp > > Lines 595-597 (patched) > > <https://reviews.apache.org/r/60203/diff/1/?file=1753516#file1753516line595> > > > > Why don't we handle this here to be consistent with other `*Class()` > > functions?
I read through the error handling chain and for rtnl_class_delete it doesn't appear to check for class existence and return an interpretable error code. I've left the current generic error handling and removed the erroneous comment. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178789 ----------------------------------------------------------- On June 19, 2017, 12:36 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60203/ > ----------------------------------------------------------- > > (Updated June 19, 2017, 12:36 p.m.) > > > Review request for mesos, Ilya Pronin, Jie Yu, Santhosh Kumar Shanmugham, and > Cong Wang. > > > Repository: mesos > > > Description > ------- > > Based heavily on Cong Wang's original review 45605. > > Introduce support for HTB class and expose configuration. > > > Diffs > ----- > > src/linux/routing/queueing/class.hpp PRE-CREATION > src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 > src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f > src/linux/routing/queueing/internal.hpp > 9fe522ee017c86af8c7b2e518cd0957af08750e4 > > > Diff: https://reviews.apache.org/r/60203/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
