----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/#review183486 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Lines 802 (patched) <https://reviews.apache.org/r/60888/#comment259507> what about nested container nested underneath the standalone container? those are recoverable as well? src/slave/paths.hpp Lines 146 (patched) <https://reviews.apache.org/r/60888/#comment259505> Hum, what about nested containers? I think we already have `getSandboxPath`. Maybe reusing that method (just the `rootSandboxPath` is different)? - Jie Yu On Aug. 21, 2017, 10:21 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60888/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 10:21 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > Although there is no way to launch standalone containers yet, > this commit outlines the expected layout of container metadata > which should be populated when launching standalone containers. > > The layout is fairly simple, as standalone containers have no > framework, executor, or tasks to worry about. The sandbox directory > will live under a new top-level directory `containers` and there is > no metadata to checkpoint at the moment. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 5772421c3078d36225b946a5286b8c1bf2f007e8 > src/slave/containerizer/mesos/paths.hpp > 12ae7c7329f9e8d334cb32c30cc38465bddc046c > src/slave/containerizer/mesos/paths.cpp > 0c61c20c345a327ec469b382558aaeed0280e754 > src/slave/paths.hpp 51b481fc0870f1e95448f85ee2fd485fceea1919 > src/slave/paths.cpp eb6a28e3bdfb520a08f6985d45f6fc1a2346d99e > > > Diff: https://reviews.apache.org/r/60888/diff/2/ > > > Testing > ------- > > See next patch and later ones too. > > > Thanks, > > Joseph Wu > >
