----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review199711 -----------------------------------------------------------
src/slave/slave.hpp Lines 1141-1143 (patched) <https://reviews.apache.org/r/66144/#comment280123> Let's add some code to `Framework::destroyExecutor()` to GC these entries when we remove the executor struct. src/slave/slave.cpp Lines 2226-2227 (original), 2226-2227 (patched) <https://reviews.apache.org/r/66144/#comment280124> Could you add a comment here explaining what's going on? Perhaps: "Use a sequence to ensure that task launch order is preserved." - Greg Mann On March 19, 2018, 6:34 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66144/ > ----------------------------------------------------------- > > (Updated March 19, 2018, 6:34 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > Up until now, Mesos does not guarantee in-order > task launch on the agent. There are two asynchronous > steps (unschedule GC and task authorization) in the > agent task launch path. Depending on the CPU scheduling > order, a later task launch may finish these two steps earlier > than its predecessors and get to the launch executor stage > earlier, resulting in out-of-order task delivery. > > This patch enforces the task delivery order by sequencing > task launch after the two asynchronous steps, specifically > right before entering `__run()`. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp 915d4f1bbd642ca5d2587cfdd846262cb7e08788 > > > Diff: https://reviews.apache.org/r/66144/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
