----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review200133 -----------------------------------------------------------
src/slave/slave.cpp Lines 2224 (patched) <https://reviews.apache.org/r/66144/#comment280782> s/refer/referred/ src/slave/slave.cpp Lines 2225 (patched) <https://reviews.apache.org/r/66144/#comment280785> s/"seqFuture"/`seqFuture`/ src/slave/slave.cpp Lines 2234-2235 (patched) <https://reviews.apache.org/r/66144/#comment280783> Is unschedule GC the only failure which could lead to this? If not, then maybe say "due to unschedule GC or some other failure". src/slave/slave.cpp Lines 2241 (patched) <https://reviews.apache.org/r/66144/#comment280786> s/tasks'/task's/ src/slave/slave.cpp Lines 2244 (patched) <https://reviews.apache.org/r/66144/#comment280787> s/sequence/the sequence/ src/slave/slave.cpp Lines 2261-2268 (patched) <https://reviews.apache.org/r/66144/#comment280814> I think we want to `return;` at the end of this conditional block? And if you make this lambda accept a string parameter, you could include the Failure message in this logging. Also, it looks like the local variable `error` is not really needed? - Greg Mann On March 28, 2018, 7:05 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66144/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 7:05 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > Up until now, Mesos does not guarantee in-order > task launch on the agent. There are two asynchronous > steps (unschedule GC and task authorization) in the > agent task launch path. Depending on the CPU scheduling > order, a later task launch may finish these two steps earlier > than its predecessors and get to the launch executor stage > earlier, resulting in out-of-order task delivery. > > This patch enforces the task delivery order by sequencing > task launch after the two asynchronous steps, specifically > right before entering `__run()`. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb > > > Diff: https://reviews.apache.org/r/66144/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
