----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review200329 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Line 2233 (original), 2274 (patched) <https://reviews.apache.org/r/66144/#comment281033> We should defer this callback. src/slave/slave.cpp Lines 2275 (patched) <https://reviews.apache.org/r/66144/#comment281034> Ditto regarding naming of `framework_` here. - Greg Mann On April 2, 2018, 6:04 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66144/ > ----------------------------------------------------------- > > (Updated April 2, 2018, 6:04 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > Up until now, Mesos does not guarantee in-order > task launch on the agent. There are two asynchronous > steps (unschedule GC and task authorization) in the > agent task launch path. Depending on the CPU scheduling > order, a later task launch may finish these two steps earlier > than its predecessors and get to the launch executor stage > earlier, resulting in out-of-order task delivery. > > This patch enforces the task delivery order by sequencing > task launch after the two asynchronous steps, specifically > right before entering `__run()`. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a > > > Diff: https://reviews.apache.org/r/66144/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
