> On March 28, 2018, 11:11 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2261-2268 (patched) > > <https://reviews.apache.org/r/66144/diff/4/?file=1989782#file1989782line2261> > > > > I think we want to `return;` at the end of this conditional block? And > > if you make this lambda accept a string parameter, you could include the > > Failure message in this logging. > > > > Also, it looks like the local variable `error` is not really needed?
We need to continue. https://github.com/apache/mesos/blob/7e58e14de74a5dd39b167d6698e79e29cdd24ac6/src/slave/slave.cpp#L2193-L2204 The failure message must have been printed early, let's print it again here. Removed `error`. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review200133 ----------------------------------------------------------- On March 29, 2018, 11:15 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66144/ > ----------------------------------------------------------- > > (Updated March 29, 2018, 11:15 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > Up until now, Mesos does not guarantee in-order > task launch on the agent. There are two asynchronous > steps (unschedule GC and task authorization) in the > agent task launch path. Depending on the CPU scheduling > order, a later task launch may finish these two steps earlier > than its predecessors and get to the launch executor stage > earlier, resulting in out-of-order task delivery. > > This patch enforces the task delivery order by sequencing > task launch after the two asynchronous steps, specifically > right before entering `__run()`. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp a4bd4ccd3fc59c3c0e462d9b480f5424b3e52d7a > > > Diff: https://reviews.apache.org/r/66144/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
