Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/251#discussion_r11055710
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
@@ -72,6 +72,20 @@ class SparkListenerSuite extends FunSuite with
LocalSparkContext with ShouldMatc
}
}
+ test("bus.stop() waits for the event queue to completely drain") {
+ val sleepyListener = new SleepyListener(1000)
--- End diff --
Relying on sleeps like here is a little bit brittle and it also means this
test will take 5 seconds which is along time. What about instead using a
synchronization mechanism and create a `BlockingListener` that will just block
inside of `onJobEnded` until it's signaled to continue.
Also -
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
