Github user concretevitamin commented on the pull request:
https://github.com/apache/spark/pull/251#issuecomment-38892043
@pwendell yeah I think I used the current approach mainly because it should
be more efficient than continuously sleeping and waiting. The task at hand
seems very well handled by a condition variable. Additionally, the current
approach is not any more complicated?
As for your second point: I thought it's safe to treat
SparkListenerShutdown (and hence stop()) as the special end-of-work / poison
message, so I agree with the semantics you proposed.
I will update the test shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
